guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] scripts: add guix lint


From: Eric Bavier
Subject: Re: [PATCH 1/2] scripts: add guix lint
Date: Tue, 22 Jul 2014 09:31:08 -0500
User-agent: mu4e 0.9.9.5; emacs 23.3.1

Ludovic Courtès writes:

> Cyril Roelandt <address@hidden> skribis:
>
>> * guix/scripts/lint.scm: New file. Defines a 'lint' tool for Guix packages.
>> * Makefile.am (MODULES): Add it.
>
> This is nice!
>
> I think this should be modular so that, when possible, checkers can also
> be invoked at macro expansion time.  For instance, style checkers for
> synopses could run just when you build the file, without even having to
> invoke ‘guix lint’ (but it’s nice to have both possibilities.)

I like this too.

Would it make sense to have 'guix lint' operate at the file/module level
instead of at the package level?  That would be consistent with other
lint-type tools, as far as I know.  It would also, I think, help with
things like syntax errors that currently result in 'guix build'
reporting something like "guix build: error: foo: unknown package".

-- 
Eric Bavier



reply via email to

[Prev in Thread] Current Thread [Next in Thread]