Re: Fwd: [PATCH] Add font-terminus.

On Sun, Aug 10, 2014 at 10:21 PM, Mark H Weaver <address@hidden> wrote:

Guy Grant <address@hidden> writes:

> Okay, patch updated as recomended; Patch attatched. Again, if
> something looks wrong -- feel free to comment. Thanks!
>
>

> From 3244099f65c1c6bd99d6b0921213c0749e04be47 Mon Sep 17 00:00:00 2001
> From: Guy Grant <address@hidden>
> Date: Sun, 10 Aug 2014 08:58:08 -0500
> Subject: [PATCH 1/1] add terminus-font
>
> ---

This needs a proper commit message. Look in the git logs for examples.

> + (inputs
> + `(("bdftopcf" ,bdftopcf)
> + ("font-util", font-util)
> + ("mkfontdir" ,mkfontdir)
> + ("perl" ,perl)))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))

I suspect that all of those inputs should instead be native-inputs. If
the code in those packages is executed at build time, then they should
be native-inputs. If the code is executed at run-time, they should be
normal inputs. The distinction is important when cross compiling.

> + (arguments
> + `(#:configure-flags (list
> + ;; install fonts into subdirectory of package output instead of
> + ;; font-util-?.?.?/share/fonts/X11
> + (string-append "--with-fontrootdir=" %output "/share/fonts/X11"))
> + #:tests? #f)) ;; No test target in tarball

Please fix the indentation here.

> + (home-page "http://terminus-font.sourceforge.net/")
> + (synopsis "Simple bitmap programming font")
> + (description "Terminus Font is a clean, fixed width bitmap font, designed for long
> + (8 and more hours per day) work with computers.")
> + (license
> + (license:x11-style
> + "http://scripts.sil.org/cms/scripts/page.php?item_id=OFL_web"))))

Otherwise looks good to me.

Thanks!
Mark

From:	Guy Grant
Subject:	Re: Fwd: [PATCH] Add font-terminus.
Date:	Tue, 12 Aug 2014 20:37:23 -0500