[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] packages: Remove dead code.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] packages: Remove dead code. |
|
Date: |
Tue, 19 Aug 2014 23:09:50 +0200 |
|
User-agent: |
Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux) |
Alex Kost <address@hidden> skribis:
> If I understand correctly, ‘_’ is redundant in “gnu/packages.scm” as it
> is already defined in (guix ui).
Indeed, applied.
> Also I fixed a double space in this commit (not sure if it's acceptable
> here).
That’s fine, IMO. If this were a wider change, like removing all
trailing whitespaces in one file or another, that would have to be a
different commit for clarity.
> Also if this patch is OK, should a commit message be improved somehow?
The commit message is good. Perhaps you wouldn’t even need to mention
the space removal.
Thanks,
Ludo’.