Re: [PATCH] utils: Preserve makefile shell arguments during patch.

[Eric Bavier]

Ludovic Courtès writes:

>>        (let* ((old (string-append dir shell))
>>               (new (or (find-shell shell) old)))
>>          (unless (string=? new old)
>>            (format (current-error-port)
>>                    "patch-makefile-SHELL: ~a: changing `SHELL' from `~a' to 
>> `~a'~%"
>>                    file old new))
>> -        (string-append "SHELL = " new "\n"))))
>> +        (string-append "SHELL = " new " " args))))
>
> Are you sure the \n is no longer needed?  (I can never remember when it
> is matched and when it’s not.)

It's no longer needed in this case, since the '.' also matches a
newline, so it will end up in 'args'.  

BTW, this is contrary to the GNU Emacs Regular Expressions documentation
which states::

  . (Period)
  is a special character that matches any single character *except a
  newline*...

I'm not sure at what level the newline is being matched, whether in
substitute* or in Guile's regex library.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html