Re: [PATCH] profiles: Report about upgrades.

[Alex Kost]

Ludovic Courtès (2014-09-02 23:45 +0400) wrote:

> Alex Kost <address@hidden> skribis:
>
>> Ludovic Courtès (2014-08-31 23:57 +0400) wrote:
>>
>> [...]
>>
>>> Perhaps even a different format, like, say:
>>>
>>>   The following package will be upgraded:
>>>     guile 1.8.8 → 2.0.9        out     /gnu/store/...
>>>
>>> Thoughts?
>>
>> I think, it would be perfect!
>
> Commit ef8993e does that.
>
> While I was at it, I took the freedom to adjust the format of these
> lines (commit 9a91476) so that the version number would always appear in
> the second column, while the output name no longer has a separate
> column:
>
> $ ./pre-inst-env guix package -r idutils -u libtasn1 -i emacs libgc 
> libgc:debug -n -p foo
> The following package would be removed:
>    idutils    4.6     /gnu/store/40nbigb0bghwqvnchjdxsrafbzxmybh8-idutils-4.6
>
> The following package would be upgraded:
>    libtasn1   3.6 → 4.1       
> /gnu/store/52kdi2gmrl2ms92as0nsxbbkndqx07s4-libtasn1-4.1
>
> The following packages would be installed:
>    libgc:debug        7.4.0   
> /gnu/store/98r76vrmvv3fvg26n3dzq3i72l25whl1-libgc-7.4.0-debug
>    libgc      7.4.0   /gnu/store/cqhp23ak0kaa4kv1jdvzbsrkw41krczh-libgc-7.4.0
>    emacs      24.3    /gnu/store/majxvz4dxcw75m1ni2hph3kbws400y94-emacs-24.3
>
> It’s still time to complain if you don’t like it.  :-)

Great!  I really like it and that ‘right-arrow’ is cool :)

There is just one thing (that shouldn't be mentioned):

+        (lambda (key . args)
+          ">")))))

I would make it "->".  IMHO it is more "understandable" as such
combination is used in output of some shell commands (like “mv -v” or
“cp -v”).

But that's a terrible nitpick and it should be ignored.