Re: [PATCH 1/2] gnu: Add minetest-data.

[Ludovic Courtès]

Hi!

Some style comments:

David Thompson <address@hidden> skribis:

> * gnu/packages/games.scm (minetest-data): New variable.
>         (method url-fetch)
>         (uri (string-append "http://www.hyperrealm.com/"; name "/"
> -                           name  "-" version  ".tar.gz")) 
> +                           name  "-" version  ".tar.gz"))
>         (sha256
>          (base32 "19nc5vq4bnkjvhk8srqddzhcs93jyvpm9r6lzjzwc1mgf08yg0a6"))))

Looks like some whitespace cleanup, which should rather be in a separate patch.

>      (build-system gnu-build-system)
> @@ -235,7 +237,7 @@ level's exit.  The game is presented in a 2D side view.")
>  into stereotyped or otherwise humorous dialects.  The filters are provided as
>  a C library, so they can easily be integrated into other programs.")
>      (license gpl2+)))
> - 
> +
>  (define-public cmatrix
>    (package
>      (name "cmatrix")
> @@ -305,11 +307,11 @@ interface or via an external visual interface such as 
> GNU XBoard.")
>      (build-system gnu-build-system)
>      (arguments
>       '(#:phases
> -       (alist-cons-before 
> +       (alist-cons-before
>          'configure 'pre-conf
>          ;; This is GNU.  So use gnuchess as the first choice of engine
>          (lambda _
> -          (substitute* "xboard.conf.in" 
> +          (substitute* "xboard.conf.in"

Ditto.

> +    (native-inputs
> +     `(("source" ,source)
> +       ("tar" ,tar)
> +       ("gzip" ,(@ (gnu packages compression) gzip))
> +       ("coreutils" ,coreutils)))

Remove coreutils.

> +    (arguments
> +     `(#:modules ((guix build utils))
> +       #:builder (begin
> +                   (use-modules (guix build utils))
> +                   (let ((tar (string-append (assoc-ref %build-inputs "tar")
> +                                             "/bin/tar"))
> +                         (cp (string-append (assoc-ref %build-inputs
> +                                                       "coreutils")
> +                                            "/bin/cp"))

Remove ‘cp’.

> +                         (path (string-append (assoc-ref %build-inputs
> +                                                         "gzip")
> +                                              "/bin")))
> +                     (setenv "PATH" path)
> +                     (system* tar "xvf" (assoc-ref %build-inputs "source"))
> +                     (chdir (string-append "minetest_game-" ,version))
> +                     (mkdir-p install-dir)
> +                     (system* cp "-r" "." install-dir)))))

Use ‘copy-recursively’ instead.

Thanks,
Ludo’.