[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] utils: Allow wrap-program to be called multiple times.
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] utils: Allow wrap-program to be called multiple times. |
Date: |
Sun, 14 Sep 2014 11:58:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> address@hidden skribis:
>
>> When compiling core-updates, I now see the following warning:
>>
>> LC_ALL=C \
>> ./pre-inst-env \
>> /home/mhw/.guix-profile/bin/guild compile -L "." -L "." \
>> -Wformat -Wunbound-variable -Warity-mismatch \
>> --target="i686-pc-linux-gnu"
>> \
>> -o "guix/build/utils.go" "guix/build/utils.scm"
>> guix/build/utils.scm:718:4: warning: "~a/.~a-wrap-~2'0d": unsupported format
>> option ~2, use (ice-9 format) instead
>> wrote `guix/build/utils.go'
>
> Oops, this needs to be fixed, indeed.
Okay, I pushed a fix to core-updates.
>> Have you verified that this call to 'format' works as expected in all
>> the relevant cases?
>
> It could be that it works in practice, because (ice-9 format) does this
> crazy thing:
>
> (module-set! the-root-module 'format format)
>
> (-Wformat is purposefully stricter, because this crazy thing should
> vanish eventually.)
Indeed, maybe we should consider fixing that for 2.2.
Thanks,
Mark