[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-ca
From: |
Cyril Roelandt |
Subject: |
[PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article. |
Date: |
Sat, 27 Sep 2014 23:49:27 +0200 |
* guix/scripts/lint.scm (check-start-article): use "string-ci=?" instead of
"string=?".
* tests/lint.scm: Add corresponding tests.
---
guix/scripts/lint.scm | 4 ++--
tests/lint.scm | 18 ++++++++++++++++++
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 5f9b6e4..ee00e5c 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -148,8 +148,8 @@ Run a set of checkers on the specified package; if none is
specified, run the ch
'synopsis)))
(define (check-start-article synopsis)
- (if (or (string=? (string-take synopsis 2) "A ")
- (string=? (string-take synopsis 3) "An "))
+ (if (or (string-ci=? (string-take synopsis 2) "A ")
+ (string-ci=? (string-take synopsis 3) "An "))
(emit-warning package
"no article allowed at the beginning of the synopsis"
'synopsis)))
diff --git a/tests/lint.scm b/tests/lint.scm
index ceb7abe..c439faa 100644
--- a/tests/lint.scm
+++ b/tests/lint.scm
@@ -97,6 +97,24 @@
(check-synopsis-style pkg))))
"no article allowed at the beginning of the synopsis")))
+(test-assert "synopsis: starts with 'a'"
+ (->bool
+ (string-contains (call-with-warnings
+ (lambda ()
+ (let ((pkg (dummy-package "x"
+ (synopsis "a bad synopsis"))))
+ (check-synopsis-style pkg))))
+ "no article allowed at the beginning of the synopsis")))
+
+(test-assert "synopsis: starts with 'an'"
+ (->bool
+ (string-contains (call-with-warnings
+ (lambda ()
+ (let ((pkg (dummy-package "x"
+ (synopsis "an awful synopsis"))))
+ (check-synopsis-style pkg))))
+ "no article allowed at the beginning of the synopsis")))
+
(test-assert "synopsis: too long"
(->bool
(string-contains (call-with-warnings
--
1.8.4.rc3
- [PATCH 0/5] Add, fix and improve checkers in guix lint., Cyril Roelandt, 2014/09/27
- [PATCH 1/5] guix lint: make sure check-patches retrieves patch names., Cyril Roelandt, 2014/09/27
- [PATCH 2/5] guix lint: Make sure synopses are not too long., Cyril Roelandt, 2014/09/27
- [PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article.,
Cyril Roelandt <=
- [PATCH 5/5] guix lint: make sure synopses do not start with the package name., Cyril Roelandt, 2014/09/27
- [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter., Cyril Roelandt, 2014/09/27
- Re: [PATCH 0/5] Add, fix and improve checkers in guix lint., Andreas Enge, 2014/09/28