Re: [PATCH] gnu: duplicity: Fix and disable some tests.

[Ludovic Courtès]

Eric Bavier <address@hidden> skribis:

> From 91ea5ded0548acb9945acd9ad110c266c79ad81b Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Sun, 28 Sep 2014 15:04:34 -0500
> Subject: [PATCH] gnu: duplicity: Fix and disable some tests.
>
> * gnu/packages/patches/duplicity-piped-password.patch: New patch.
> * gnu/packages/patches/duplicity-test_selection-tmp.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add them.
> * gnu/packages/backup.scm (duplicity)[source]: Add patches field.  [inputs]:
>   Add util-linux and tzdata.  [arguments]: rename patch-tests phase to
>   check-setup.  Set HOME and TZDIR for tests.

Each [field] should start on a new line.

> +                 (lambda* (#:key inputs #:allow-other-keys)
>                     (substitute* "testing/functional/__init__.py"
> -                     (("/bin/sh") (which "sh"))))
> +                     (("/bin/sh") (which "sh")))
> +                   (setenv "HOME" (getcwd)) ;gpg needs to write to $HOME
> +                   (setenv "TZDIR"
> +                           (string-append (assoc-ref inputs "tzdata")
> +                                          "/share/zoneinfo")))

Could you add a comment saying what needs TZDIR?

> +++ b/gnu/packages/patches/duplicity-piped-password.patch
> @@ -0,0 +1,20 @@
> +This test, on three occasions, is failing with the error:
> +
> +  EOF: End Of File (EOF) in read_nonblocking(). Braindead platform.

:-)

OK to commit with these changes.

Thank you!

Ludo’.