Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter.

[Cyril Roelandt]

On 09/28/2014 06:09 PM, Ludovic Courtès wrote:
> Cyril Roelandt <address@hidden> skribis:
> 
>> * guix/scripts/lint.scm (check-description-style, 
>> check-synopsis-start-upper-case): New methods
>> * tests/lint.scm: Test them.
> 
> Please specify the test names, and wrap lines.
> 
>> +(define (start-with-upper-case s)
>> +  (char-set-contains? char-set:upper-case (string-ref s 0)))
> 
> Rather ‘starts-with-capital-letter?’ (with the question mark, as is
> conventional, and more grammatically correct I think.)
> 
> Also it may be worth checking that S has one or more character, so
> gracefully handle empty synopses.
> 
Not sure whether the "starts-with-capital-letter" function would make a
lot of sense with an empty string, that why I test this in the caller.
WDYT ?


> OK to push with these changes, thanks!
> 
> Ludo’.
>