Re: [PATCH] gnu: Add xboing

[Ludovic Courtès]

John Darrington <address@hidden> skribis:

> On Mon, Oct 13, 2014 at 02:27:48PM +0200, Ludovic Court??s wrote:
>      John Darrington <address@hidden> skribis:
>      
>      > * gnu/packages/games.scm (xboing): New variable.
>
>      [...]
>      
>      > +    (inputs `(("libx11" ,libx11)
>      > +            ("libxext" ,libxext)
>      > +            ("libxpm" ,libxpm)))
>      > +    (native-inputs `(("imake" ,imake)
>      > +                   ("inetutils" ,inetutils)
>      > +                   ("makedepend" ,makedepend)))
>      
>      Please align opening parenthesis and use only spaces, no tabs (for Emacs
>      23 and later, .dir-locals.el normally sets it up.)
>
> This was formatted by emacs using indent-region.  Shouldn't that do the job?
> loading .dir-locals.el results in an error for me.

Emacs 23+ loads it automatically.  Otherwise, drop:

  (setq indent-tabs-mode nil)

somewhere in ~/.emacs.

>      > +    (license x11-style)))
>      
>      ???x11-style??? is a procedure, so it should be:
>      
>        (x11-style URI [COMMENT])
>      
>      Make sure it???s not really ???x11??? or ???expat???.
>
> It is neither of those, although similar.  The trouble is, I don't think that 
> there is a URI for the license.  It is contained in the tarball.

See other uses: it’s fine to use file://COPYING, say, as the URI to the
license, if the only copy is within the tarball.

Also, it’s even better if you can add a comment above saying what’s
different from the X11 license text.

Thanks,
Ludo’.