guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] Factor out a common pattern into a procedure.


From: Mark H Weaver
Subject: Re: [PATCH 1/1] Factor out a common pattern into a procedure.
Date: Sun, 19 Oct 2014 10:43:29 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.94 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> John Darrington <address@hidden> skribis:
>
>> How about something like (string-take-fields "1.22.3.04.5" 3) which would 
>> return "1.22.3"
>
> Agreed.  What ‘version-prefix’, with the optional argument defaulting
> to 2?

I also like 'version-prefix', although I'd favor making it a required
argument.  The improved code clarity is well worth two extra characters.
I don't feel strongly though.

>> Possibly an optional argument specifying the separator might be useful too.
>
> I think that’d be overkill.

Agreed.

     Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]