guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add ruby 1.8.7


From: Pjotr Prins
Subject: Re: [PATCH] gnu: Add ruby 1.8.7
Date: Mon, 27 Oct 2014 02:56:50 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote:
> In broad strokes, we use the GNU changelog conventions:
> 
>   http://www.gnu.org/prep/standards/html_node/Change-Logs.html
> 
> but with some minor formatting differences.  However, the best thing is
> to look in the commit history for examples close to what you're doing.
> 
> There is brief mention of this in the "Submitting Patches" section of
> the HACKING file in the source tree.

I read those earlier. I used a commit message we used before. I think
that if you are serious about convention you should point to a real
list of allowed standard messages. Now it looks arbitrary and
makes the submitter look stupid.

> >> It looks like the 'native-search-paths' field needs to be overridden,
> >> since the existing one has "2.1.3" in it.
> >
> > I don't think it is used by 1.8.7. Does that matter?
> 
> Yes, otherwise users who install ruby 1.8.7 will be advised to set
> GEM_PATH to $HOME/.guix-profile/lib/ruby/gems/2.1.3.

Ah, that is what it is for. Actually the build did not give me that
message. I DO get a load of messages such as

  
strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/ruby/1.8/rexml/attlistdecl.rb:
  File format not recognized

is there a way to prevent files with a .rb extension or ruby shebang
to be stripped?

Pj.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]