[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 2/2] gnu: Add gnome-themes-standard. |
Date: |
Tue, 04 Nov 2014 17:52:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Federico Beffa <address@hidden> skribis:
> On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Courtès <address@hidden> wrote:
>>> +;; The version of this package should be the same as the version of
>>> +;; gnome-desktop.
>>> +(define-public gnome-themes-standard
>>> + (package
>>> + (name "gnome-themes-standard")
>>> + (version "3.10.0")
>>
>> Please use (version (package-version gnome-desktop)) here, and put the
>> comment just above it.
>
> I thought about this, but did not do it because, if the version
> changes, then you also need to change the hash. So, if someone
> changes gnome-desktop without bothering about gnome-themes-standard,
> then the latter would break.
I think using (package-version gnome-desktop) would make the intent
clear, and the breakage that would occur would give a heads-up and an
incentive to fix it.
How does that sound?
Ludo’.