guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: fix some issues cross-compiling glib


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: fix some issues cross-compiling glib
Date: Tue, 18 Nov 2014 21:36:10 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

John Darrington <address@hidden> skribis:

> From: John Darrington <address@hidden>
>
> * gnu/packages/glib.scm (glib) : Moved inputs to native-inputs,
>   and change "inputs" to "%build-inputs"

OK for the former, but why the latter?  In general I think it’s
stylistically better to refer to the ‘inputs’ argument.

Also, what about somehow grouping big-rebuild changes together?  I’m
slightly worried by the post-release chaos that might occur.  :-)
Maybe core-updates, or maybe a more specific branch for
cross-compilation fixes?

> +      ;; The following ought to be achieved by (native-self-input #t).
> +      ;; Unfortunately it seems to only set glib:out.  We want glib:bin

Missing period at end of sentence.

(And you found a bug!)

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]