Re: Add hexchat

[Andreas Enge]

On Fri, Nov 21, 2014 at 06:44:34PM +0100, Julien Lepiller wrote:
> here is the patch for hexchat I was asked to write.

This looks very clean, thank you! A few minor comments:

+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://dl.hexchat.net/hexchat/hexchat-"; version 
".tar.xz"))
+              (sha256
+               (base32 
"1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))

This goes a bit beyond the 80 columns limit (as many other packages, in fact).
I think we should indent them rather like this:
    (source
      (origin
        (method url-fetch)
          (uri (string-append
                "https://dl.hexchat.net/hexchat/hexchat-"; version ".tar.xz"))
          (sha256
            (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))
Did I get it right (by hand, without emacs)?

+    (native-inputs `(("pkg-config" ,pkg-config)
+              ("intltool" ,intltool)))

This should be alined like this:
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("intltool" ,intltool)))
Or with the literal list starting on the line following "native-inputs".

Andreas