guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.


From: Eric Bavier
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Fri, 21 Nov 2014 16:24:12 -0600
User-agent: mu4e 0.9.9.5; emacs 23.3.1

Ludovic Courtès writes:

> Eric Bavier <address@hidden> skribis:
>
>> * gnu/packages/patches/subversion-propagate-env-to-hooks.patch: New patch.
>> * gnu-system.am (dist_patch_DATA): Add it.
>> * gnu/packages/version-control.scm (subversion): Use it.
>
> [...]
>
>> +++ b/gnu/packages/patches/subversion-propagate-env-to-hooks.patch
>> @@ -0,0 +1,14 @@
>> +* Hooks need to inherit environment variables such as PATH, otherwise simple
>> +  things like `ls` might fail in a hook.
>
> What’s the upstream status of this patch?  I’m imagine it a useful
> property even for FHS distros.  IOW, what about submitting it upstream
> if it’s not already done?

It looks like they did change the behavior in 1.8.  I can't tell at this
point from the source if it would fix our use-case.  If it does, perhaps
we could upgrade our subversion to 1.8.10?

> That looks good, but I want to make sure we’re not changing something
> that was purposefully made this way.

If the behavior is similar in 1.8.10, I'll get in contact with the
developers.

-- 
Eric Bavier

Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



reply via email to

[Prev in Thread] Current Thread [Next in Thread]