Re: [PATCH] gnu: atlas: Try to fix build on MIPS.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> I would like to propose the attached patch to try to fix the MIPS
> package.  I'm not sure if this really help, but I do not have a way to
> test it locally.

The change makes sense, so I think it’s OK to commit it and see what
happens.  Mark or some other MIPS user can always chime in anytime.

> From 64235b3012ebf6ac337a8615dd91ae08beb95180 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Sat, 22 Nov 2014 16:42:41 +0100
> Subject: [PATCH] gnu: atlas: Try to fix build on MIPS.
>
> * gnu/packages/maths.scm (atlas): Add MIPS specific configure flags.

[...]

> +         ;; Probe is failing for MIPS.  We therefore define the system
> +         ;; architecture explicitly by setting (-A) MACHINETYPE = 49
> +         ;; 'MIPSR1xK' and (-V) ISA = 1 'none'.
> +         ,,@(when (string-prefix? "mips" (%current-system))
> +              (list "-A" "49" "-V" "1"))

This should be an ‘if’:

  (if (string-prefix? ...)
      ...
      '())

You can check on Intel that this modification doesn’t change the result
of the ‘guix build atlas’.

OK to push afterwards.

Thank you,
Ludo’.