Re: [PATCH] gnu: Add pyparsing.

[Cyril Roelandt]

On 11/25/2014 06:51 PM, Federico Beffa wrote:
> Cyril Roelandt <address@hidden> writes:
> 
>>
>> Maybe you could add the PyPI mirror here.
>>
> 
> I'm not sure I understand. Do you mean replace or really add? A second
> uri field? Could you give an example? The sourceforge download site is
> the one mentioned on the homepage.

Yes. The "uri" field can be a list (see libpng for instance). It would
be nice to have two reliable mirrors here.

> 
>>
>> There is a "unitTests.py" that can be run manually, if I'm not mistaken.
>> Maybe you could replace the check phase ?
>>
> 
> I do not think so.  I do not see any reference to tests in the README
> and other source files and I can't find a file called "unitTests.py".

Oh, that might just be in the SVN repository, then.

> 
>>
>> I trust you on the doc thing :) Is it something that could somehow be
>> part of the python build system?
>>
> 
> I'm not a python expert :-) From the few packages that I prepared
> lately, I have the impression that each python library does something
> different with the documentation.

Sad but true.

> 
>>
>> Do not start the synopsis by "a". You may want to run "guix lint" on
>> your package to find such issues.
>>
> 
> Ooops, forgot to run that.
> 
> Thanks for the review,

Thanks for the package!

Cyril.