Re: [PATCH] gnu: Add numpy.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> From cdf0c1a3193d1855d8b1a512042f91a56c82ea28 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Mon, 1 Dec 2014 13:28:24 +0100
> Subject: [PATCH] gnu: Add numpy.
>
> * gnu/packages/python.scm (python-numpy, python2-numpy): New variables.

[...]

> +                    ;; Generation of the info file fails.

Please add FIXME or XXX.  ↑

> +                    (map (lambda (file)
> +                           (copy-file (string-append "build/latex" file)
> +                                      (string-append doc file)))
> +                           '("/numpy-ref.pdf" "/numpy-user.pdf"))

Please use ‘for-each’ instead of ‘map’ (because it’s a for-effect
iteration), and align the file list with “(lambda”.

> +                      (map (lambda (file)

‘for-each’ as well.

OK to push with these changes.

Thanks!

Ludo’.