Re: [PATCH] gnu: Add wmctrl.

[Alex Kost]

Ludovic Courtès (2014-12-06 17:15 +0300) wrote:

> Alex Kost <address@hidden> skribis:

[...]
>> - Is it ok to make "wmctrl.scm" or would it be more appropriate to put
>>   it into "xdisorg.scm"?
>
> xdisorg.scm would seem preferable to me.

OK, then I think "unclutter" should go there as well.  What about "scrot"?

>> +  gnu/packages/patches/wmctrl-64-fix.patch
>
> Missing backslash.

Ouch, it was missed somehow.

>> +    (synopsis "Command-line tool to control X Window Manager")
>
> “to control X11 window managers”
>
>> +    (description
>> +     "Wmctrl allows to interact with an X Window Manager that is compatible
>> +with the EWMH/NetWM specification.  It can query the Window Manager for
>
> “window manager” (lower case.)

Thanks, I'll fix the case.

> OK to push with these adjustments.

I have not committed yet: I have a concern that "wmctrl" will bring a
dependency on (gnu packages glib) to “xdisorg.scm”.  Would it be a
problem?  However I see that xdisorg uses (gnu packages xorg) and xorg
uses (gnu packages xdisorg), so probably not.

-- 
Alex