Re: [PATCH] gnu: add msmtp

[David Thompson]

Hey there!  Thanks for the patch!

Tomáš Čech <address@hidden> writes:

> * gnu/packages/msmtp.scm: New file.
> ---
>  gnu/packages/msmtp.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 gnu/packages/msmtp.scm
>
> diff --git a/gnu/packages/msmtp.scm b/gnu/packages/msmtp.scm
> new file mode 100644
> index 0000000..0cf01d4
> --- /dev/null
> +++ b/gnu/packages/msmtp.scm
> @@ -0,0 +1,46 @@
> +(define-module (gnu packages msmtp)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages compression)
> +  #:use-module (gnu packages libidn)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages gsasl)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  )
> +
> +(define-public msmtp
> +  (package
> +   (name "msmtp")
> +   (version "1.4.32")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append 
> "http://downloads.sourceforge.net/project/msmtp/msmtp/";
> +                      version "/msmtp-" version ".tar.bz2"))

Align version with the opening quote on the previous line.

> +     (sha256 (base32
> +           "122z38pv4q03w3mbnhrhg4w85a51258sfdg2ips0b6cgwz3wbw1b"))))
> +   (build-system gnu-build-system)
> +   (inputs
> +    `(("libidn" ,libidn)
> +      ("gnutls" ,gnutls)
> +      ("zlib" ,zlib)
> +      ("gsasl" ,gsasl)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (home-page "http://msmtp.sourceforge.net/";)
> +   (arguments
> +    `(#:configure-flags (list "--with-libgsasl"
> +                           "--with-libidn"
> +                           "--with-ssl=gnutls")))

Align "--with-libidn" and "--with-ssl=gnutls" with "--with-libgsasl".

> +   (synopsis
> +    "SMTP client")

Expand a bit.

> +   (description
> +    "msmtp is an SMTP client.  In the default mode, it transmits a mail to
> +an SMTP server (for example at a free mail provider) which takes care of 
> further
> +delivery.  To use this program with your mail user agent (MUA), create
> +a configuration file with your mail account(s) and tell your MUA to call
> +msmtp instead of /usr/sbin/sendmail.")

The part about "/usr/sbin/sendmail" isn't relevant to Guix.

> +   (license license:gpl3+)))
> -- 
> 2.1.2

You forgot to add this new file to GNU_SYSTEM_MODULES in gnu-system.am,
but I think this package should go in gnu/packages/mail.scm instead of a
standalone module.  Could you move it?

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate