Re: [PATCH v3] gnu: Add bullet.

[David Thompson]

Hello again,

Missed one thing during my previous review.

Tomáš Čech <address@hidden> writes:

> * gnu/packages/game-development.scm: New file
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu-system.am                     |  1 +
>  gnu/packages/game-development.scm | 43 
> +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 gnu/packages/game-development.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index e923340..481a9a7 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -95,6 +95,7 @@ GNU_SYSTEM_MODULES =                                \
>    gnu/packages/freeipmi.scm                  \
>    gnu/packages/ftp.scm                               \
>    gnu/packages/fribidi.scm                   \
> +  gnu/packages/game-development.scm          \
>    gnu/packages/games.scm                     \
>    gnu/packages/gawk.scm                              \
>    gnu/packages/gcal.scm                              \
> diff --git a/gnu/packages/game-development.scm 
> b/gnu/packages/game-development.scm
> new file mode 100644
> index 0000000..72e73dd
> --- /dev/null
> +++ b/gnu/packages/game-development.scm
> @@ -0,0 +1,43 @@
[snip]
> +(define-public bullet
> +  (package
> +    (name "bullet")
> +    (version "2.82")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "https://bullet.googlecode.com/files/bullet-";
> +                                  version "-r2704.tgz"))

I remember there being some discussion about dashes in version numbers,
and I can't remember the outcome.  If there's no issue, I think that the
"-r2704" should be part of the version number string.

> +              (sha256
> +               (base32 
> "1lnfksxa9b1slyfcxys313ymsllvbsnxh9np06azkbgpfvmwkr37"))))
> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f)) ; no 'test' target
> +    (home-page "http://bulletphysics.org/";)
> +    (synopsis "3D physics engine library")
> +    (description
> +     "Bullet is a physics engine library usable for collision detection.  It 
> +is used in some video games and movies.")
> +    (license zlib)))
> -- 
> 2.0.4
>
>

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate