Re: [PATCH] gnu: Add samtools

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

>>>>> Can we disable the test suite for certain architectures?  Or would they
>>>>> have to be disabled completely?
>>>
>>> Since it fails the same way on mips64el, I suggest this instead:
>>>
>>>    #:tests? (string=? (or (%current-system) (%current-target-system))
>>>                           "x86_64-linux")
>>
>> Oops, we forgot to mention that there should be a comma before that
>> first open paren, like this:
>>
>>     #:tests? ,(string=? (or (%current-system) (%current-target-system))
>>                             "x86_64-linux")
>
> Attached is a patch that disables the tests on all systems but
> x86_64-linux.  I'm unsure about the indentation, though.  Should the
> compared string really be aligned with the arguments of `(or' (as shown
> above), or rather aligned with `(or', the argument to `(string=?' (as in
> the attached patch)?

The patch uses the right alignment.

When in doubt, you can check “Formatting Code” in ‘HACKING’ (although I
admit the style guidelines it refers to is quite verbose.)

> From c9846248c28f2c22660c156d4275326fe8afac80 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 15 Dec 2014 12:23:01 +0100
> Subject: [PATCH] gnu: samtools: disable tests for non-64-bit systems
>
> * gnu/packages/bioinformatics.scm (samtools): disable tests for all non-64-bit
>   systems because of an upstream bug in the test data.

Applied, thanks!

Ludo’.