Re: [PATCH] gnu: Add bowtie.

[Ricardo Wurmus]

>> +        'patch-makefile
>> +        (lambda _
>> +          (substitute* "Makefile"
>> +            (("^CC = .*$") (string-append "CC = " (which "gcc")))
>> +            (("^CPP = .*$") (string-append "CPP = " (which "g++")))
>> +            ;; replace BUILD_HOST and BUILD_TIME for deterministic build
>> +            (("-DBUILD_HOST=.*") "-DBUILD_HOST=\"\\\"guix\\\"\"")
>> +            (("-DBUILD_TIME=.*") "-DBUILD_TIME=\"\\\"0\\\"\"")))
>
> Could you make this a ‘snippet’?  It suffices to write “CC = gcc” and
> “CPP = g++”.  That way, running ‘guix build -S bowtie’ will return
> source that’s closer to what we’re using.

Okay.

>> +    (license license:gpl3)))
>
> From a quick glance, this should be ‘gpl3+’ (source file headers carry
> the “or any later version” phrase.)

I went by the NEWS and MANUAL files that say

  "Bowtie 2 is licensed under the GPLv3 license."

and

  "Bowtie 2 is distributed under the [GPLv3 license]"

but I have updated the package recipe to use `gpl3+' as the source file
headers do indeed carry the phrase "or any later version".


> Could you post an updated patch?

Please see the attached patch.

Thanks for the review!
Ricardo


PS: This depends on the Perl module "Clone" for which I sent a patch
previously.  Although you said it was applied I haven't yet seen it in
the git repository.

0001-gnu-Add-bowtie.patch
Description: Text Data