Re: [PATCH] services: xorg: Make SLiM sessions configurable.

[Ludovic Courtès]

宋文武 <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> 宋文武 <address@hidden> skribis:
>>
>>> From 144bf00b86f6884615d986598ccc62a3c4747eef Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
>>> Date: Tue, 16 Dec 2014 00:21:46 +0800
>>> Subject: [PATCH] services: xorg: Make SLiM sessions configurable.
>>>
>>> * gnu/services/xorg.scm (%default-xsessions): New variable.
>>>   (xsessions-directory): New procedure.
>>>   (slim-service): Add #:sessions and #:auto-login-session parameters.
>>>   [slim.cfg]: Honor #:sessions.
>>>   (xinitrc): Adjust accordingly.
>>
>> LGTM.  However, please leave .xsession (instead of .xinitrc) in this
>> patch.  The change to .xinitrd should be done separately.
>>
>>> +          ;; First, try to run ~/.xinitrc with the specified session.
>>> +          (exec-from-login-shell (string-append home "/.xinitrc") session)
>>> +          ;; Then starts the specified session directly.
>>> +          (exec-from-login-shell session))))
>>
>> s/Then starts/Then try to start/
>>
>> OK to push with these two changes.
> Done, thanks for review!

Great.

> OK, it seem that only SLiM use ~/.xinitrc instead of ~/.xsession.
> IMO, It's fine to stick with ~/.xsession if we add other login
> managers later.

Sounds good to me.

Thank you!

Ludo’.