Re: [PATCH]: Add CUPS.

[Ricardo Wurmus]

Ludovic Courtès writes:

> Ricardo Wurmus <address@hidden> skribis:
>
>> There are a couple of problems with this package, one of which is that
>> the test suite is failing for some reason.  I have not been able to
>> figure out why the "cupsFileFind" test fails, so I disabled the tests.
>
> OK.  Do you have any more details from the test suite log?

I looked at this again and suddenly figured out what went wrong
(hardcoded search path for "cat" in a call to "cupsFileFind").  The
tests take a good while longer now and there are seven more failures
that I will work on before resubmitting an updated patch.

> The reason for splitting would be if it turns out that the include
> directory takes a fair amount of space that is not needed in many
> cases.  If that’s the case, then splitting makes sense.  That may well
> be the case: what’s the side of each of these outputs?

I see that splitting would not be required in this case; the outputs are
very small (6+MB for "out" and 240+kB for "include").

>> +    (license license:gpl2+)))
>
> Isn’t it GPLv2-only?

You are right (I was so sure I checked this).  I'll fix this in the
updated patch.

Best,
Ricardo