Re: [PATCH] gnu: Add support for the 'armhf-linux' system

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> From 4a9d9c327b501b43c96cb42859329a7d1a9520b5 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Wed, 31 Dec 2014 04:23:12 -0500
> Subject: [PATCH] gnu: Add support for the 'armhf-linux' system.
>
> Based on preliminary work by John Darrington <address@hidden>.
>
> * gnu/packages/bootstrap/armhf-linux/bash,
>   gnu/packages/bootstrap/armhf-linux/mkdir,
>   gnu/packages/bootstrap/armhf-linux/tar,
>   gnu/packages/bootstrap/armhf-linux/xz: New files.
>
> * gnu-system.am (bootstrap_armhf_linuxdir, dist_bootstrap_armhf_linux_DATA)
>   (nodist_bootstrap_armhf_linux_DATA): New variables.
>   (DISTCLEANFILES): Add $(nodist_bootstrap_armhf_linux_DATA).
>   (gnu/packages/bootstrap/armhf-linux/guile-2.0.11.tar.xz): New target.
> * build-aux/download.scm (file-name->uri): Use newer date in URI for
>   armhf-linux.
> * gnu/packages/bootstrap.scm (raw-build): Use "guile-2.0.11.tar.xz" on
>   armhf-linux.
>   (glibc-dynamic-linker, %bootstrap-coreutils&co, %bootstrap-binutils)
>   (%bootstrap-glibc, %bootstrap-gcc): Add armhf-linux cases.
> * .gitignore: Add gnu/packages/bootstrap/armhf-linux/guile-2.0.11.tar.xz.

No need to log .gitignore changes.

> * gnu/packages/gcc.scm (gcc-configure-flags-for-triplet): Add armhf case.
>   (gcc-4.7)[pre-configure]: Add gcc/config/*/linux-eabi.h to the list
>   of files in which to patch GLIBC_DYNAMIC_LINKER.
>
> * gnu/packages/cross-base.scm (xgcc-armhf): New variable.
> * guix/utils.scm (gnu-triplet->nix-system, nix-system->gnu-triplet):
>   Add armhf cases.
>
> * m4/guix.m4 (GUIX_SYSTEM_TYPE): Add armhf case.
>   (GUIX_ASSERT_SUPPORTED_SYSTEM): Add armhf-linux to list of
>   supported systems.
> * doc/guix.texi (GNU Distribution): Add armhf-linux to the list of
>   supported systems.

This looks perfect!

One request: could you make the gcc.scm, cross-base.scm, and utils.scm
changes a separate patch, since they constitute the first logical step?

Thanks a lot for all the work!

Ludo’.