[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] import: Factorize utility functions.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 2/4] import: Factorize utility functions. |
|
Date: |
Fri, 09 Jan 2015 14:36:41 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Eric Bavier <address@hidden> skribis:
> * guix/import/pypi.scm (hash-table->alist, flatten, assoc-ref*,
> url-fetch, json-fetch): Pull functions from here and...
> * guix/import/gnu.scm (file-sha256): here out into...
> * guix/import/utils.scm: Here, and...
> * guix/import/json.scm: Here. New file.
> * Makefile.am (MODULE)[guile-json]: Add it.
Should be:
* Makefile.am (MODULES)[HAVE_GUILE_JSON]: Add it.
> * tests/pypi.scm (pypi->guix-package): Update mock module reference.
LGTM, but could you move ‘file-sha256’ to (guix hash) instead, below
‘port-sha256’?
> --- a/guix/import/gnu.scm
> +++ b/guix/import/gnu.scm
> @@ -1,4 +1,4 @@
> -;;; GNU Guix --- Functional package management for GNU
> +;; GNU Guix --- Functional package management for GNU
Typo.
Thanks,
Ludo’.