Re: [PATCH] gnu: Add ninja.

[宋文武]

Mark H Weaver <address@hidden> writes:

> address@hidden (Ludovic Courtès) writes:
>
>> 宋文武 <address@hidden> skribis:
>>
>>> * gnu/packages/ninja.scm: New file.
>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>>
>> [...]
>>
>>> +          'check
>>> +          (lambda _
>>> +            (and (zero? (system "./configure.py"))
>>> +                 (zero? (system "./ninja ninja_test"))
>>> +                 ;; SubprocessTest.InterruptChild fail when using 
>>> 'system*'.
>>> +                 ;; SubprocessTest.SetWithLots was skipped.
>>> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make this 
>>> test go.
>>
>> Does it mean that the test is currently failing?
>
> This test failed during the core-updates x86_64 build on Hydra.  We get:
>
>   [166/183] SubprocessTest.InterruptChild
>   *** Failure in src/subprocess_test.cc:83
>   ExitInterrupted == subproc->Finish()
>
> In the hopes that it might be a transient failure, I restarted the
> build, but the second time it failed in the same place.  See:
>
>   http://hydra.gnu.org/build/201077/nixlog/1/raw
>   http://hydra.gnu.org/build/201077/nixlog/2/raw
>
> It seems that using 'system' instead of 'system*' wasn't enough to make
> it work reliably.  Can you take another look?
OK, I pushed a patch to disable the test.
>
> Thanks for your contributions!
>
>       Mark