[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: Add IcedTea 6
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH]: Add IcedTea 6 |
Date: |
Thu, 29 Jan 2015 10:47:17 +0100 |
Ludovic Courtès writes:
>> I rewrote this to instead check the generated test logs in test/ for
>> lines starting with "Error:" or "FAILED:". To disable tests I wrapped
>> it in an (or #t ...) as the argument #:tests? #f does not disable a
>> custom check phase.
>>
>> 'check
>> (lambda _
>> ;; The "make check-*" targets always return zero, so we need
>> to
>> ;; check for errors in the associated log files to determine
>> ;; whether any tests have failed.
>> (use-modules (ice-9 rdelim))
>> (let* ((error-pattern (make-regexp "^(Error|FAILED):.*"))
>> (checker (lambda (port)
>> (let loop ((_ #t))
>
> You can make it (let loop () ... (loop)).
Ah, right. Fixed.
> One last thing: perhaps we can directly remove mips64el-linux from
> ‘supported-platforms’?
Is it known to not build on mips64el?
> OK to push.
I pushed without disabling any platform yet. Based on the build results
I will update the package.
> Thanks,
> Ludo’.
Cheers,
Ricardo