Re: [PATCH] gnu: Add polipo.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 34a01e8bf1977c722ae06cf0e4238ec2a27796dc Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Sun, 1 Feb 2015 00:03:19 +0100
> Subject: [PATCH] gnu: Add polipo.
>
> * gnu/packages/web.scm: Add polipo.

For better or worse, our convention is to write this as:

* gnu/packages/web.scm (polipo): New variable.

> ---
>  gnu-system.am        |  1 +
>  gnu/packages/web.scm | 37 ++++++++++++++++++++++++++++++++++++-
>  2 files changed, 37 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 706ad57..03f148d 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -222,6 +222,7 @@ GNU_SYSTEM_MODULES =                              \
>    gnu/packages/photo.scm                     \
>    gnu/packages/pkg-config.scm                        \
>    gnu/packages/plotutils.scm                 \
> +  gnu/packages/polipo.scm                    \
>    gnu/packages/polkit.scm                    \
>    gnu/packages/popt.scm                              \
>    gnu/packages/pth.scm                               \

This change is no longer appropriate, since polipo.scm doesn't exist.
Otherwise it looks good.  Can you send an updated patch?

     Thanks,
       Mark