Re: [PATCH]: Add Ant.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> this patch adds ant-minimal, a minimal configuration of Apache Ant.  Ant
> can be configured with lots of optional libraries, but since most of
> these libraries are built with Ant, I think it makes sense to provide a
> minimal version.

Yes.

> A wart is that Ant (even in the minimal configuration) depends on
> hamcrest-core, which can only be built with Ant.  The good news is that
> it appears that hamcrest-core is only used for running the tests after
> Ant is built.

What you did (referring to hamcrest-core.jar) is fine.  Turning off
tests in ant-minimal would also be fine, IMO; perhaps even preferable,
since that avoids another pre-build binary.  WDYT?

> I used the gnu-build-system instead of the trivial-build-system, because
> using the trivial-build-system required me to write a lot more code in
> order to unpack the tarball, patch shebangs, add tools to the PATH,
> etc.  Using the gnu-build-system I only had to remove a few phases to
> make it work.  Maybe we need a somewhat more powerful version of the
> trivial-build-system.

Makes sense.

> From a8cf4bbd4a8147215a84f27e4aa6247163b4fdf4 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 30 Jan 2015 16:57:13 +0100
> Subject: [PATCH] gnu: Add Ant.
>
> * gnu/packages/java.scm (ant-minimal): New variable.
> ---
>  gnu/packages/java.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 4a86f63..46ff798 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -48,6 +48,54 @@
>    #:use-module (gnu packages zip)
>    #:use-module (gnu packages texinfo))
>  
> +(define-public ant-minimal
> +  (package
> +    (name "ant")

s/ant/ant-minimal/

Perhaps it could additionally be made private, because users will have
no reason to use the minimal variant, no?

> +    (description
> +     "Ant is a platform-independent build tool for Java.")

Could you expound a bit, saying it’s similar to ‘make’, has build
recipes written in XML, is especially convenient for Java projects,
etc.?

I’ll reply to your other comments.

Thanks,
Ludo’.