[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: problem with building gcc-cross-4.8.3 for i686-pc-gnu
From: |
Ludovic Courtès |
Subject: |
Re: problem with building gcc-cross-4.8.3 for i686-pc-gnu |
Date: |
Thu, 05 Feb 2015 13:38:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Marek Benc <address@hidden> skribis:
> The attached patch does the following:
> 1.) Adds the name of the dynamic linker to gnu/packages/bootstrap.scm
> 2.) Adds code to gnu/package/gcc to substitute the default dynamic
> linker in gcc/config/arch/gnu.h for the one to be used.
> 3.) Changes how the build system arguments for cross-gcc are created:
> A.) They're now in a separate procedure, reflecting how it's done
> in vanilla guix.
> B.) A bug is fixed that caused the native ld.so to be picked over
> the target one.
> C.) Fixed the 'set-cross-path phase so that it also checks for
> hurd-related packages, and checks package existence before passing
> anything to the string-handling functions.
This all looks good to me. However, this should really be 5 different
patches so as to ease review, bisection, etc. Could you do that?
Please prefer one message per patch, as with ‘git send-email’.
TIA!
Ludo’.
- Re: problem with building gcc-cross-4.8.3 for i686-pc-gnu,
Ludovic Courtès <=