Re: [PATCH] gnu: Add ngircd.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> +    (arguments
> +     `(#:configure-flags
> +       `("--with-gnutls" "--with-iconv" "--enable-ipv6"
> +         ,,@(if (string-suffix? "-linux"
> +                                (or (%current-target-system)
> +                                    (%current-system)))
> +                '("--with-pam")
> +                '()))

There's no need for two levels of quasiquote here, and it unnecessarily
complicates the unquoting.  How about changing the inner quasiquote to
normal quote?  It should come out like this:

    (arguments
     `(#:configure-flags
       '("--with-gnutls" "--with-iconv" "--enable-ipv6"
         ,@(if (string-suffix? "-linux"
                               (or (%current-target-system)
                                   (%current-system)))
               '("--with-pam")
               '()))

> +       #:phases
> +       ;; Necessary for the test suite, should it be enabled in the future.

You can remove the ", should it be enabled in the future".

Modulo these little nitpicks, it looks good to me.  Please push!

     Thanks,
       Mark