Re: [PATCH] utils: Strip duplicates from search path.

[Ludovic Courtès]

Eric Bavier <address@hidden> skribis:

> The attached patch (for core-updates) removes duplicate entries from
> search paths.  I believe this is safe.

Yes, I think so.

> I was encountering "command line too long" errors while trying to
> build several higher-level perl modules, and noticed that the values
> being set for PERL5LIB, PATH, and others were ~318kb each.
> Investigating further, many of the entries were duplicates, resulting
> from the many propagated inputs that are needed in perl modules.

Ouch, OK.

> While it's possible that, even with this patch, we could encounter the
> same errors in the future, it hasn't happened yet, and I've been able
> to continue packaging modules for hydra.  If it does become a problem
> again, we could consider patching the perl modules themselves to point
> to their dependent modules, thus alleviating the need to propagate so
> many inputs.

Let’s hope we don’t get this far.  ;-)

> From f54561ac020a996c0a20f658dea29529ed7dc6b5 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Wed, 4 Feb 2015 09:48:39 -0600
> Subject: [PATCH] utils: Strip duplicates from search path.
>
> * guix/build/utils.scm (search-path-as-list): Delete duplicate input
>   directories before searching.

OK for ‘core-updates’.

Thanks,
Ludo’.