Re: [PATCH] gnu: Add libcap-ng.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> From bb312c479e9f3384fc85abfa1d7be543a3cc0fa3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Sun, 8 Feb 2015 15:45:30 +0100
> Subject: [PATCH 1/2] gnu: Add libcap-ng.
>
> * gnu/packages/admin.scm (libcap-ng): New variable.
> ---
>  gnu/packages/admin.scm | 28 +++++++++++++++++++++++++++-
>  1 file changed, 27 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index b1666bd..dacae60 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -52,7 +52,8 @@
>    #:use-module (gnu packages libusb)
>    #:use-module (gnu packages libftdi)
>    #:use-module (gnu packages image)
> -  #:use-module (gnu packages xorg))
> +  #:use-module (gnu packages xorg)
> +  #:use-module (gnu packages python))
>  
>  (define-public dmd
>    (package
> @@ -1000,3 +1001,28 @@ within the file system where it occurred.  Thus, 
> \"direvent\" provides an
>  easy way to react immediately if given files undergo changes, for example, to
>  track changes in important system configuration files.")
>      (license gpl3+)))
> +
> +(define-public libcap-ng
> +  (package
> +    (name "libcap-ng")
> +    (version "0.7.4")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://people.redhat.com/sgrubb/libcap-ng/libcap-ng-";
> +                    version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ssvnh4cvhya0c1j6k6192zvqcq7nc0x01fb5nwhr0prfqr0i8j8"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("python" ,python)))
> +    (home-page "http://people.redhat.com/sgrubb/libcap-ng/";)
> +    (synopsis "Library for more easily working with POSIX capabilities")
> +    (description
> +     "The libcap-ng library is intended to make programming with POSIX
> +capabilities easier than the traditional libcap library.  It includes
> +utilities that can analyse all currently running applications and print out
> +any capabilities and whether or not it has an open ended bounding set.  The
> +included utilities are designed to let admins and developers spot apps from
> +various ways that may be running with too much privilege.")
> +    (license gpl2+)))

The programs are gpl2+ licensed, but the library has license lgpl2.1+.
Therefore you should write (license (list lgpl2.1+ gpl2+)) and include a
comment clarifying the situation.

Also add your copyright notice.

Otherwise looks good to me.

    Thanks,
      Mark