Re: [PATCH]: gnu: Add lash.

[David Thompson]

Ricardo Wurmus <address@hidden> writes:

> Attached is a patch to add lash, an audio application session handler.
>
> ~~ Ricardo
>
> From 19edc131b719981a9545867bf167daa642551a08 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 13 Feb 2015 23:20:00 +0100
> Subject: [PATCH] gnu: Add lash.
>
> * gnu/packages/audio.scm (lash): New variable.
> ---
>  gnu/packages/audio.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 81e07c2..d0e1842 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -256,6 +256,43 @@ synchronous execution of all clients, and low latency 
> operation.")
>  to be plugged into a wide range of audio synthesis and recording packages.")
>      (license license:lgpl2.1+)))
>  
> +(define-public lash
> +  (package
> +    (name "lash")
> +    (version "0.6.0-rc2")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://savannah/lash/lash-"
> +                   (string-map (lambda (x) (if (char=? x #\-) #\~ x)) 
> version)

How about splitting the string on #\- and then joining on #\~ instead?

> +                   ".tar.bz2"))
> +             (file-name (string-append name "-" version ".tar.gz"))

The extension should be ".tar.bz2".

> +             (sha256
> +              (base32
> +               "12z1vx3krrzsfccpah9xjs68900xvr7bw92wx8np5871i2yv47iw"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("bdb" ,bdb)
> +       ("gtk" ,gtk+-2)
> +       ("jack" ,jack-1)
> +       ("libuuid" ,util-linux)
> +       ("readline" ,readline)
> +       ("python" ,python-2)))
> +    (propagated-inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("dbus" ,dbus)
> +       ("libxml2" ,libxml2)))

I'm always wary of propagated inputs, but I'll take your word for it. :)

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "http://www.nongnu.org/lash/";)
> +    (synopsis "Audio application session manager")
> +    (description
> +     "LASH is a session management system for audio applications.  It allows
> +you to save and restore audio sessions consisting of multiple interconneced
> +applications, restoring program state (i.e. loaded patches) and the
> +connections between them.")
> +    (license license:gpl2+)))
> +
>  (define-public liblo
>    (package
>      (name "liblo")
> -- 
> 2.1.0
>

Could you send an updated patch?  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate