Re: [PATCH]: add freepats and timidity

[Ricardo Wurmus]

Andreas Enge writes:

> On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote:
>> +(define-public timidity++
>> +  (package
>> +    (name "timidity++")
>
> Back to names... I would call this "timidity". The package guidelines only
> state that underscores are replaced by "-", but the general idea would be
> to replace special characters with dashes, and to rather drop them at the end
> (or beginning) of a package name.

The homepage of TiMidity++ says

    TiMidity++ is based on TiMidity 0.2i, written by Tuukka Toivonen
    <address@hidden>*1, released on 1995. No new version of this original
    project is developed since then. Development has been continued by
    Masanao Izumo et al. in the new project named TiMidity++. ++ is to
    show the difference from original project.

I'd rather not change the name.  For reference, Fedora calls the package
"timidity++" as well.

>> +          (let ((out (string-append (assoc-ref %outputs "out")
>> +                                    "/share/timidity")))
>> +            (mkdir-p out)
>> +            (call-with-output-file
>> +                (string-append out "/timidity.cfg")
>
> It is a bit strange to have config files in /share and not in /etc, but that
> is indeed where by default timidity looks for its config file. Nevertheless,
> I would use
>   (string-append (assoc-ref %outputs "out") "/etc/timidity")
> and then add the configure flag
>   (string-append "--with-default-path=" (assoc-ref %outputs "out") 
> "/etc/timidity")

I don't mind either way, but I do agree that coercing TiMidity++ to look
in a more traditional location for the configuration file sounds like a
good idea.

~~ Ricardo