Re: [PATCH] gnu: ecl: Update to version 15.2.21.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 33e2fa3853b067ff46513b58a485fef53c1f406b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Sat, 21 Feb 2015 22:28:45 +0100
> Subject: [PATCH] gnu: ecl: Update to version 15.2.21.
>
> * gnu/packages/lisp.scm (ecl): Update to version 15.2.21, and disable the test
>   suite which now seems to require the presence of /etc/protocols.
> ---
>  gnu/packages/lisp.scm | 43 ++++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 21 deletions(-)
>
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index fe9cdab..f7fa4f8 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -94,7 +94,7 @@ interface to the Tk widget system.")
>  (define-public ecl
>    (package
>      (name "ecl")
> -    (version "13.5.1")
> +    (version "15.2.21")
>      (source
>       (origin
>         (method url-fetch)
> @@ -102,7 +102,7 @@ interface to the Tk widget system.")
>                             (version-major+minor version)
>                             "/ecl-" version ".tgz"))
>         (sha256
> -        (base32 "18ic8w9sdl0dh3kmyc9lsrafikrd9cg1jkhhr25p9saz0v75f77r"))))
> +        (base32 "05di23v977byf67rq5bdshw8lqbby1ycbscdcl1vca0z6r1s204j"))))
>      (build-system gnu-build-system)
>      (native-inputs `(("which" ,which)))
>      (inputs `(("gmp" ,gmp)
> @@ -110,25 +110,26 @@ interface to the Tk widget system.")
>                ("libgc" ,libgc)
>                ("libffi" ,libffi)))
>      (arguments
> -     '(#:phases
> -       ;; The test-suite seems to assume that ECL is installed.  So re-order
> -       ;; the phases, then reference the installed executable.
> -       (let* ((check-phase (assq-ref %standard-phases 'check))
> -              (rearranged-phases
> -               (alist-cons-after 'install 'check check-phase
> -                                 (alist-delete 'check %standard-phases))))
> -         (alist-cons-before
> -          'check 'pre-check
> -          (lambda* (#:key outputs #:allow-other-keys)
> -            (substitute* '("build/tests/Makefile")
> -              (("ECL=ecl")
> -               (string-append
> -                "ECL=" (assoc-ref outputs "out") "/bin/ecl"))))
> -          rearranged-phases))
> -       ;; Parallel builds explicitly not supported:
> -       ;; http://sourceforge.net/p/ecls/bugs/98/
> -       #:parallel-build? #f

Did they fix parallel builds upstream?

> -       #:parallel-tests? #f))
> +     '(#:tests? #f
> +       ;; The test-suite seems to require /etc/protocols to be in place, 
> which
> +       ;; our build environment doesn't have.  Should the test suite be
> +       ;; enabled, the following might be necessary:
[...]

Could we disable only the specific tests that need /etc/protocols?
How many failures are there?

     Thanks,
       Mark