Re: Add sysfsutils, cpufrequtils

[Ludovic Courtès]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") skribis:

> From a2edf2d2cec85d02e3a3848499706544be0e0961 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Wed, 18 Feb 2015 21:20:38 +0100
> Subject: [PATCH 1/3] gnu: Add sysfsutils.
>
> * gnu/packages/linux.scm (sysfsutils): New variable.

LGTM.

> From e7a1705f8d5719cdd88ca681252d34a0f7b586c0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Wed, 18 Feb 2015 22:17:01 +0100
> Subject: [PATCH 2/3] gnu: Add sysfsutils-1.
>
> * gnu/packages/linux.scm (sysfsutils-1): New variable.

[...]

> +          (substitute* '("Makefile.in")
> +            (("includedir = /usr/include/sysfs")
> +             "includedir = @includedir@"))
> +          (substitute* '("configure")
> +            (("includedir='(\\$\\{prefix\\}/include)'" all orig)
> +             (string-append "includedir='" orig "/sysfs'"))))

Could you make these a ‘snippet’ in the ‘origin’ instead?

Also, note that the first argument to ‘substitute*’ can be a plain
string instead of a list.

> From ae4cba1a57fc64294d5ec3b667ab482f7cc7d27e Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Wed, 18 Feb 2015 21:20:57 +0100
> Subject: [PATCH 3/3] gnu: Add cpufrequtils.
>
> * gnu/packages/linux.scm (cpufrequtils): New variable.
> * gnu/packages/patches/cpufrequtils-fix-aclocal.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

LGTM.

Thanks!

Ludo’.