Re: [PATCH] gnu: Add libsbsms.

[Ludovic Courtès]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") skribis:

> address@hidden (Ludovic Courtès) writes:
>
>>> +        (lambda* (#:key inputs #:allow-other-keys)
>>> +          ;; Originally a symlink to 
>>> '/usr/local/share/automake-1.12/ar-lib'.
>>> +          (delete-file "ar-lib")
>>> +          (symlink
>>> +           (string-append (assoc-ref inputs "automake") "/share/automake-"
>>> +                          ,(package-version automake) "/ar-lib")
>>> +           "ar-lib"))
>>
>> I think it could just run “automake --add-missing” instead, which is
>> lightly more elegant and future-proof.
>
> That seems to lead to:
>
> configure.ac:119: error: version mismatch.  This is Automake 1.15,
> configure.ac:119: but the definition used by this AM_INIT_AUTOMAKE
> configure.ac:119: comes from Automake 1.12.  You should recreate
> configure.ac:119: aclocal.m4 with aclocal and run automake again.
> configure.ac:119: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its 
> use is discouraged.
> configure.ac:119: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' 
> macro instead,
> configure.ac:119: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your 
> Makefile.am files.
> configure.ac:39: installing './ar-lib'
>
> It works if I just run 'autoreconf -vif'.  Is that fine?
>
> I have to additionally add autoconf and libtool as inputs for that by
> the way.

Yes, which is a bit wasteful.

In that case your initial solution is better IMO.

OK to push it, then!

Thank you,
Ludo’.