Re: [PATCH 1/5] gnu: Add efl.

[Andreas Enge]

Hello,

a few more comments:

On Thu, Feb 26, 2015 at 01:31:09AM +0100, Tomáš Čech wrote:
> +    (propagated-inputs
> +     `(("bullet" ,bullet)
> +       ("dbus" ,dbus)
> +       ("eudev" ,eudev)
> +       ("fontconfig" ,fontconfig)
> +       ("freetype" ,freetype)
> +       ("fribidi" ,fribidi)
> +       ("glib" ,glib)
> +       ("libpng" ,libpng)
> +       ("libsndfile" ,libsndfile)
> +       ("luajit" ,luajit)
> +       ("openssl" ,openssl)
> +       ("pulseaudio" ,pulseaudio)
> +       ("util-linux" ,util-linux)))

Why do all these need to be propagated? Are the all dlopenend? If they are
linked normally into executables and libraries, are ld-wrapper should take
care of them. If all or some of them need to be propagated, it would be good
to add a comment.

> * gnu/packages/efl (elementary): New variable.

This one looks safe (except for the line length of 80 characters already
mentioned by 宋文武).

> * gnu/packages/efl.scm (evas-generic-loaders): New variable.
> +       ("poppler" ,poppler)
> +       ))

The "))" should be at the end of the previous line. Apart from that,
it looks good.

> * gnu/packages/efl.scm (emotion-generic-players): New variable.

Looks good.

> * gnu/packages/efl.scm (terminology): New variable.

Looks good, too!

Andreas