Re: [PATCH] Update ncmpcpp to v0.6.2

[Mark H Weaver]

David Thompson <address@hidden> writes:

> Paul van der Walt <address@hidden> writes:
[...]
>> +    (arguments
>> +     '(#:configure-flags
>> +       '("BOOST_LIB_SUFFIX=")
>> +       #:phases
>> +       (alist-cons-after
>> +        'unpack 'autogen
>> +        (lambda _
>> +          (substitute* "autogen.sh"
>> +            (("/bin/sh") (which "bash")))
>
> Is "autogen.sh" not executable?  If it starts with a shebang, Guix
> should patch the file appropriately.

The problem here is that this 'autogen' phase is run before the
'patch-source-shebangs' phase, at my suggestion.  It has to be that way,
because 'patch-source-shebangs' (and 'patch-usr-bin-file') will need to
be run on the files created by 'autogen.sh'.

>> +          (setenv "NOCONFIGURE" "true")
>> +          (zero? (system* "bash" "autogen.sh")))
>
> If its executable, you can say:
>
>     (zero? (system* "./autogen.sh"))

Yes, after the 'substitute*' above, this should presumably work.  My
guess is that Paul added the "bash" here before he realized that he
also needed the 'substitute*'.

      Mark