Re: [PATCH 1/7] gnu: Add girara.

[宋文武]

2015-03-02 7:47 GMT+08:00 Paul van der Walt <address@hidden>:
> * gnu/packages/gtk.scm (girara): Add variable.
> ---
>  gnu/packages/gtk.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 81f912e..2b62b99 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright © 2014, 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2014 Eric Bavier <address@hidden>
>  ;;; Copyright © 2015 Federico Beffa <address@hidden>
> +;;; Copyright © 2015 Paul van der Walt <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,6 +29,7 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system waf)
> +  #:use-module (gnu packages gettext)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages ghostscript)
> @@ -770,3 +772,45 @@ extensive documentation, including API reference and a 
> tutorial.")
>  targetted at GTK 2.x, and can be used in conjunction with gnome-python to
>  write GNOME applications.")
>      (license license:lgpl2.1+)))
> +
> +(define-public girara
> +  (package
> +    (name "girara")
> +    (version "0.2.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append 
> "https://pwmt.org/projects/girara/download/girara-";
> +                              version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1phfmqp8y17zcy9yi6pm2f80x8ldbk60iswpm4bmjz5217jwqzxh"))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (arguments
> +     `(#:make-flags
> +       `(,(string-append "PREFIX=" (assoc-ref %outputs "out"))
> +         "COLOR=0" "CC=gcc")
> +       #:test-target "test"
> +       #:phases
> +       (alist-delete
> +        'check
I think pass '#:tests? #f' with a comment instead of delete
the check phase is more clear.
> +        (alist-delete
> +         'configure
> +         %standard-phases))))
> +    (inputs `(("gtk+" ,gtk+)
> +              ("glib" ,glib)
> +              ("gettext" ,gnu-gettext)))
If gettext only used at build time (most case), it shoud be a 'native-inputs'.
And gtk+ should be a 'propagate-inputs', because it's in the girara.pc,
and referred by header files.
And I think glib is not needed here, it should just be propagated by gtk+,
if not then it's a bug ;-)
> +    (build-system gnu-build-system)
> +    (home-page "https://pwmt.org/projects/girara/";)
> +    (synopsis "library for minimalistic gtk+3 user interfaces")
> +    (description "girara is a library that implements a user interface that
> +focuses on simplicity and minimalism. Currently based on GTK+, a
> +cross-platform widget toolkit, it provides an interface that focuses on three
> +main components: A so-called view widget that represents the actual
> +application, an input bar that is used to execute commands of the
> +application and the status bar which provides the user with current
> +information. girara was designed to replace and enhance the user interface
> +that is used by zathura and jumanji and other features that those 
> applications
> +share.")
Both should start with a uppercase, and we use period followed by two spaces
as sentences separator.
You can  use './pre-inst-env guix lint girara'  to get more tips.
> +    (license license:zlib)))
> --
> 2.3.1
>
>