Re: 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc.

[Mark H Weaver]

address@hidden (Ludovic Courtès) writes:

> Mark H Weaver <address@hidden> skribis:
>
>> Ludovic Courtès <address@hidden> writes:
>>
>>> commit ec4a4c46efaf2e7373f331654640f1321c0f2e62
>>> Author: Ludovic Courtès <address@hidden>
>>> Date:   Sat Feb 28 22:44:31 2015 +0100
>>>
>>>     services: xorg: Fix file descriptor leak from SLiM/xinitrc.
>>>     
>>>     Previously processes started from the window manager would have a couple
>>>     of leaked file descriptors: writable /var/log/slim.log and readable
>>>     /gnu/store/…-xinitrc.
>>>     
>>>     * gnu/services/xorg.scm (xinitrc)[builder]: Add 'close-all-fdes'.  Use
>>>       it in 'exec-from-login-shell'.
>>
>> This commit broke XFCE, so I've reverted it until we can investigate
>> further.
>
> I’ve had a couple of glitches too, which are apparently due to the fact
> that this patch closes FDs 0, 1, and 2, which it shouldn’t.
>
> Can you confirm that starting from FD 3 works for you too?

Yes, starting from FD 3 works.

    Thanks!
      Mark