Re: [PATCH 4/8] gnu: Add zathura.

[Paul van der Walt]

On 2015-03-02 at 21:19, quoth Mark H Weaver:
> It's not important, but the way we usually write this is:
> [...]
> We don't generally describe what new files are for in the commit log.
> Such explanations belong in the files themselves.

Will fix!

> For consistency, please use tabs before the "\", and keep the blank line
> above the MISC_DISTRO_FILES definition.

Done.

> Since the environment variable can hold a path with more than one
> directory, it is misnamed.  How about ZATHURA_PLUGIN_PATH instead?
>
> Also the code above could be simplified.
> How about something like this: (untested)

That looks quite elegant, will try it. Thanks for the suggestion!

>     dir = g_getenv("ZATHURA_PLUGIN_PATH");
>
> What do you think?

Using your name and approach :)

> Probably the description should start with a capital letter, and I would
> remove "and functional" and "as well as an easy usage" which sound like
> marketing-speak.

True.

> Please move this next to 'native-inputs'.

I'll neaten them all up a bit.

Expect a pile of patches promptly.

Thanks,
p.