Re: [PATCH] Add openlibm.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> From 636e19fd0649cf18264dde64f76449f6b5d8e70c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 9 Mar 2015 11:07:13 +0100
> Subject: [PATCH] gnu: Add openlibm.
>
> * gnu/packages/maths.scm (openlibm): New variable.

[...]

> +    (synopsis "System-independent, portable libm implementation")

What about “Portable C mathematical library (libm)”?

> +    ;; From LICENSE.md:
> +    ;;   "The OpenLibm code derives from the FreeBSD msun and OpenBSD libm
> +    ;; implementations, which in turn derives from FDLIBM 5.3. As a result, 
> it
> +    ;; has a number of fixes and updates that have accumulated over the years
> +    ;; in msun, and also optimized assembly versions of many functions. These
> +    ;; improvements are provided under the BSD and ISC licenses. The msun
> +    ;; library also includes work placed under the public domain, which is
> +    ;; noted in the individual files. Further work on making a standalone
> +    ;; OpenLibm library from msun, as part of the Julia project is covered
> +    ;; under the MIT license. The test files, test-double.c and test-float.c
> +    ;; are under the LGPL."
> +    (license (list license:expat license:isc license:bsd-2 
> license:lgpl2.1+))))

Compared to the paragraph, the list misses ‘license:x11’.

Also, it’s enough to write “See LICENSE.md for details.”  No need to
copy the whole text IMO.

OK to push with these changes.

Thank you!

Ludo’.