Re: [PATCH 2/2] gnu: bind-utils: Add new variable.

[Mark H Weaver]

Tomáš Čech <address@hidden> writes:

> * gnu/packages/dns.scm (bind-utils): New variable.
> ---
>  gnu/packages/dns.scm | 61 
> ++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 59 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
> index 86f5945..7420247 100644
> --- a/gnu/packages/dns.scm
> +++ b/gnu/packages/dns.scm
> @@ -17,7 +17,13 @@
>  ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>  
>  (define-module (gnu packages dns)
> -  #:use-module (guix licenses)
> +  #:use-module (gnu packages databases)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages openssl)
> +  #:use-module (gnu packages perl)
> +  #:use-module (gnu packages xml)
> +  #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system gnu))
> @@ -53,4 +59,55 @@ addresses to appear in the DNS with names configured 
> either in each host or in
>  a central configuration file.  Dnsmasq supports static and dynamic DHCP 
> leases
>  and BOOTP/TFTP for network booting of diskless machines.")
>      ;; Source files only say GPL2 and GPL3 are allowed.
> -    (license (list gpl2 gpl3))))
> +    (license (list license:gpl2 license:gpl3))))
> +
> +(define-public bind-utils
> +  (package
> +    (name "bind-utils")
> +    (version "9.10.1-P2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "ftp://ftp.isc.org/isc/bind9/"; version
> +                                  "/bind-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1svzia5vv0s4bv6r04j8bsvlf3klwyigmdz1iwb4fqds00iyvp22"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     ;; it would be nice to add GeoIP and gssapi once there is package
> +     `(("libcap" ,libcap)
> +       ("libxml2" ,libxml2)
> +       ("mysql" ,mysql)
> +       ("openssl" ,openssl)
> +       ("perl" ,perl)
> +       ("p11-kit" ,p11-kit)))
> +    (arguments
> +     `(#:tests? #f ; no test phase implemented
> +       #:configure-flags
> +       (list (string-append "--with-openssl="
> +                            (assoc-ref %build-inputs "openssl"))
> +             (string-append "--with-dlz-mysql="
> +                            (assoc-ref %build-inputs "mysql"))
> +             (string-append "--with-pkcs11="
> +                            (assoc-ref %build-inputs "p11-kit")))
> +       #:phases
> +       (alist-replace
> +        'build
> +        (lambda _
> +          (system* "make" "-C" "lib/dns")
> +          (system* "make" "-C" "lib/isc")
> +          (system* "make" "-C" "lib/bind9")
> +          (system* "make" "-C" "lib/isccfg")
> +          (system* "make" "-C" "lib/lwres")
> +          (system* "make" "-C" "bin/dig"))
> +        (alist-replace
> +         'install
> +         (lambda _ (system* "make" "-C" "bin/dig" "install"))

You should check the status codes returned by 'make', like this
(untested):

--8<---------------cut here---------------start------------->8---
       (alist-replace
        'build
        (lambda _
          (and (zero? (system* "make" "-C" "lib/dns"))
               (zero? (system* "make" "-C" "lib/isc"))
               (zero? (system* "make" "-C" "lib/bind9"))
               (zero? (system* "make" "-C" "lib/isccfg"))
               (zero? (system* "make" "-C" "lib/lwres"))
               (zero? (system* "make" "-C" "bin/dig"))))
        (alist-replace
         'install
         (lambda _ (zero? (system* "make" "-C" "bin/dig" "install")))
--8<---------------cut here---------------end--------------->8---

> +         %standard-phases))))
> +    (home-page "https://www.isc.org/downloads/bind/";)
> +    (synopsis "Tools for quering nameserver")

"quering" is mispelled, and "nameserver" should be plural.  How about
"Tools for querying nameservers"?

> +    (description
> +     "ISC referrence implementation of nameserver - Bind comes with set of 
> tools
> +for quering nameservers.  These tools are useful for analysis of DNS issues 
> or
> +verification of configuration")

How about just:

--8<---------------cut here---------------start------------->8---
    (description
     "These tools, included with ISC BIND, are useful for analysis of DNS 
issues or
verification of configuration.")
--8<---------------cut here---------------end--------------->8---

     Thanks!
       Mark