Re: [PATCH 1/2] store: Add query-path-info operation.

[Ludovic Courtès]

David Thompson <address@hidden> skribis:

> From e72bd43190bd561f7d96810a93f3b30f5f741343 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Tue, 17 Mar 2015 10:19:36 -0400
> Subject: [PATCH 1/2] store: Add query-path-info operation.
>
> * guix/store.scm (<path-info>): New record type.
>   (read-path-info): New procedure.
>   (read-arg): Add 'path-info' syntax.
>   (query-path-info): New variable.

[...]

> +  (reg-time path-info-reg-time)

Please change the procedure name to ‘path-info-registration-time’.

> +(define-operation (query-path-info (store-path path))
> +  "Return the derivation store path for PATH."
> +  path-info)

Invalid docstring.

Could you add a test in tests/store.scm?  It could add a file with
‘add-text-to-store’, with a non-empty reference list, and check its
references and hash, for instance.

Thanks!

Ludo’.